-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hostnetwork back to Node Daemonset #1130
Add hostnetwork back to Node Daemonset #1130
Conversation
Efs-utils requires IMDS to find the region of a file system. We will change this in a future release of efs-utils, but for now, we have to roll back and add host network back to the Node Daemonset.
Hi @RyanStan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, RyanStan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Efs-utils requires IMDS to find the region of a file system. We will change this in a future release of efs-utils, but for now, we have to roll back and add host network back to the Node Daemonset.
Is this a bug fix or adding new feature?
This will fix #1111.
More details, which I've copied from a comment on the above issue:
What testing is done?
Tested applying static provisioning example with egress to IMDS blocked.