-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allocate GIDs in increasing order #1182
allocate GIDs in increasing order #1182
Conversation
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Hi @RomanBednar, can you squash the commits. |
8e76481
to
493cea2
Compare
@mskanth972 Sure, done. |
/lgtm |
/unhold |
Is this a bug fix or adding new feature?
This is a bug fix/followup for: #850
The patch fixes GID allocator and changes allocation to be in descending order. While this would probably not cause any issues it makes sense to stick to he the original GID allocation which used ascending order.
What is this PR about? / Why do we need it?
Existing clusters would start allocating GIDs from highest to lowest which is reversed to what was used before. The range is determined by
gidRangeStart
andgidRangeEnd
parameters of a storage class. This does not pose any risk, however there is no reason to change the ordering (it was changed by mistake).What testing is done?
Unit tests + manual verification.
StorageClass used:
GID allocation is ascending with this patch: