-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the apiversion in storageclass.yaml #1193
Conversation
The SC manifest contained a deprecated ApiVersion, updated the same.
|
Welcome @Rajit11! |
Hi @Rajit11. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Rajit11, thanks for the PR. You are true, will merge this change. |
/lgtm |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, Rajit11 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! @mskanth972 |
The SC manifest contained a deprecated ApiVersion, updated the same.
Is this a bug fix or adding new feature?
Bug Fix
What is this PR about? / Why do we need it?
The sc manifest wouldn't work without updating the apiversion, so the efs-csi-driver check is useless without it.
What testing is done?
I deployed the whole stack after updating the apiversion of the sc manifest and it worked absolutely fine.