Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable efs-utils version check #1272

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

RyanStan
Copy link
Contributor

@RyanStan RyanStan commented Feb 15, 2024

A "version check" feature was introduced into v1.35.1 of efs-utils. This check runs once an hour and may result in the watchdog process making API calls to Github. This commit disables this feature.

We are disabling this feature because it doesn't provide any useful functionality to users of the CSI driver, and it results in unexpected API requests to Github.

What testing is done?

I deployed the csi driver and asserted that the version check wasn't executing. I checked the version check file and watchdog logs to assert the version check wasn't occurring.

bash-4.2# cat /var/log/amazon/efs/mount-watchdog.log
2024-02-15 20:23:43 UTC - INFO - amazon-efs-mount-watchdog, version 1.35.1, is enabled and started
bash-4.2# ls /var/run/efs/ | grep version
bash-4.2#
bash-4.2# cat /etc/amazon/efs/efs-utils.conf | grep enable_version_check
enable_version_check = false


@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @RyanStan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2024
@seanzatzdev-amazon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2024
@seanzatzdev-amazon
Copy link
Contributor

/retest-required

A "version check" feature was introduced into v1.35.1 of efs-utils. This
check runs once an hour and may result in the watchdog process making
API calls to Github. This commit disables this feature.
@seanzatzdev-amazon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2024
@seanzatzdev-amazon
Copy link
Contributor

/approved

1 similar comment
@seanzatzdev-amazon
Copy link
Contributor

/approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RyanStan, seanzatzdev-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9d532eb into kubernetes-sigs:master Feb 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants