-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable efs-utils version check #1272
Disable efs-utils version check #1272
Conversation
Hi @RyanStan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest-required |
A "version check" feature was introduced into v1.35.1 of efs-utils. This check runs once an hour and may result in the watchdog process making API calls to Github. This commit disables this feature.
b1d1824
to
2b90864
Compare
/lgtm |
/approved |
1 similar comment
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RyanStan, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A "version check" feature was introduced into v1.35.1 of efs-utils. This check runs once an hour and may result in the watchdog process making API calls to Github. This commit disables this feature.
We are disabling this feature because it doesn't provide any useful functionality to users of the CSI driver, and it results in unexpected API requests to Github.
What testing is done?
I deployed the csi driver and asserted that the version check wasn't executing. I checked the version check file and watchdog logs to assert the version check wasn't occurring.