Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding new regions' dns suffixes to watchdog #1455

Merged
merged 2 commits into from
Sep 23, 2024
Merged

adding new regions' dns suffixes to watchdog #1455

merged 2 commits into from
Sep 23, 2024

Conversation

jdwtf
Copy link
Contributor

@jdwtf jdwtf commented Sep 17, 2024

Is this a bug fix or adding new feature?
It is an extension of the watchdog functionality to allow mounts in new regions that have custom dns domain suffixes.

What is this PR about? / Why do we need it?

What testing is done?
No additional functionality was added, just updating the embedded config file so did not add any additional testing. make test passes all tests (attached).
4c54256.make_test.output.txt.gz

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jdwtf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2024
@jdwtf
Copy link
Contributor Author

jdwtf commented Sep 17, 2024

linking issue #1454

@mskanth972
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2024
@jdwtf
Copy link
Contributor Author

jdwtf commented Sep 17, 2024

/retest

@jdwtf
Copy link
Contributor Author

jdwtf commented Sep 17, 2024 •
edited
Loading

test failures are rust/cargo dependencies failing to setup in prow:

 #12 47.18 	cargo is needed by amazon-efs-utils-2.0.4-2.amzn2.x86_64
#12 47.18 	rust is needed by amazon-efs-utils-2.0.4-2.amzn2.x86_64

this has been failing for a bit: ref PR #1451

@jdwtf jdwtf mentioned this pull request Sep 19, 2024
Open
@jdwtf
Copy link
Contributor Author

jdwtf commented Sep 20, 2024

/retest

@jdwtf
Copy link
Contributor Author

jdwtf commented Sep 23, 2024

@mskanth972 is there more needed before we can merge?

@mskanth972
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdwtf, mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3886bd8 into kubernetes-sigs:master Sep 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@mskanth972 mskanth972

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdwtf @k8s-ci-robot @mskanth972