Only publish if access type is 'mount', not 'block'

[wongma7]

Is this a bug fix or adding new feature? fix

What is this PR about? / Why do we need it? It's possible for a user to specify an EFS volume in their pod's volumeDevices in which case kubelet will call MapVolume on the volume and pass access type 'block' in NodePublish. Since it doesn't make sense to consume EFS as a block volume, the driver should return a clear error in this case instead of unnecessarily mounting the volume.

This is exercised by the test case "should fail to create pod by failing to mount volume." Right now the driver passes the test because AttachFileDevice fails and then subsequent mounts fail with 'mount already exists' errors. Ideally the driver should pass the test by "fast failing" and there should be a FailedMapVolume event.

What testing is done? FailedMapVolume shows up on the pod:

  Warning  FailedMapVolume  2s (x8 over 66s)  kubelet, ip-192-168-115-67.us-west-2.compute.internal  MapVolume.SetUp failed for volume "pvk29ck" : kubernetes.io/csi: blockMapper.publishVolumeForBlock failed: rpc error: code = InvalidArgument desc = Volume capability access type must be mount

[wongma7]

/hold

[wongma7]

/retest
/hold cancel

[wongma7]

/test pull-aws-efs-csi-driver-e2e

[nckturner]

/lgtm

[wongma7]

think I need to rebase.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nckturner]

/lgtm