Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helm config to enable deleteAccessPointRootDir #412

Conversation

KarstenSiemer
Copy link
Contributor

@KarstenSiemer KarstenSiemer commented Apr 14, 2021

Is this a bug fix or adding new feature?
This is a new feature. (Also includes very minor fix for the log level in the controller deployment for the log level)
What is this PR about? / Why do we need it?
It adds the ability to enable the --delete-access-point-root-dir flag on the controller deployments efs-plugin sidecar.
What testing is done?
Talked about the flag in #411
I'd suggest to use it like this in helm. If the value is set to false or is omitted, then the flag will be set to false. If the value is set to true, then it will be set to true. This way we don't have to change the chart again, if the default behavior of the flag will be changed, like if it would default to true.
Merged this pr in my fork and rolled it out in a cluster.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @KarstenSiemer!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @KarstenSiemer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2021
@KarstenSiemer
Copy link
Contributor Author

/assign @leakingtapan

@wongma7
Copy link
Contributor

wongma7 commented Apr 14, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2021
@KarstenSiemer KarstenSiemer force-pushed the feat/helm-add-config-to-enable-deleteAccessPointRootDir branch from 274be81 to e4bf8ba Compare April 15, 2021 15:05
@KarstenSiemer
Copy link
Contributor Author

lessened coverage makes sense in this case. But do we want to write tests for the helm chart?
How do we want to proceed with this pr?

@wongma7
Copy link
Contributor

wongma7 commented Apr 21, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KarstenSiemer, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@wongma7
Copy link
Contributor

wongma7 commented Apr 21, 2021

@KarstenSiemer don't worry about ocveralls, it's bugged sometimes, I will merge once the other Required tests pass.

@wongma7 wongma7 merged commit 00d2689 into kubernetes-sigs:master Apr 21, 2021
k8s-ci-robot added a commit that referenced this pull request Apr 29, 2021
release-1.2: Release 1.2.1 and chart 1.2.3 with cherry-picked helm chart changes #380 #412 #413 #414 #426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants