Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PRs from master branch to branch v1.3 - MergePRstoBranchV1.3 #719

Conversation

Ashley-wenyizha
Copy link
Contributor

Is this a bug fix or adding new feature?
Merging below PRs from master to branch 1.3

What is this PR about? / Why do we need it?
#585 - Conditionally added AWS_STS_REGIONAL_ENDPOINTS flag
#681 - Removing Dependency on IMDS, allowing hostNetwork: true to be removed
#707 - Support e2e test EFS create on EKS clusters by finding EKS node subnets
#717 Upgrade gopkg.in yaml.v3

What testing is done?

holmesb and others added 10 commits June 21, 2022 15:30
…fs-plugin container. Is needed to create persistent volumes on private EKS clusters. Without this, dynamic pv creation errors: "Failed to fetch File System info: Describe File System failed"
… back to k8s API

To do this we put the IMDS requirements behind a MetadataProvider object that can also call to k8s if required. This has also beefed up the E2E tests to cover EKS properly and added unit tests around the new changes.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ashley-wenyizha
To complete the pull request process, please assign kbasv after the PR has been reviewed.
You can assign the PR to them by writing /assign @kbasv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 21, 2022
@Ashley-wenyizha Ashley-wenyizha changed the base branch from release-1.3 to release-1.4 June 21, 2022 21:14
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2022
@Ashley-wenyizha Ashley-wenyizha changed the base branch from release-1.4 to release-1.3 June 21, 2022 21:20
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2022
@k8s-ci-robot
Copy link
Contributor

@Ashley-wenyizha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-efs-csi-driver-e2e 9ee33bf link true /test pull-aws-efs-csi-driver-e2e
pull-aws-efs-csi-driver-external-test-eks 9ee33bf link true /test pull-aws-efs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants