Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uid/gid Readme #752

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

Ashley-wenyizha
Copy link
Contributor

Is this a bug fix or adding new feature?

Doc update - Document existing access point user identity enforcement behaviors in README.

#748

^^ As Daniel is blocked by the EasyCLA issue, re-submitting this PR through my account.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ashley-wenyizha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2022
@wongma7
Copy link
Contributor

wongma7 commented Aug 8, 2022

/lgtm

/test pull-aws-efs-csi-driver-verify

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@Ashley-wenyizha
Copy link
Contributor Author

failed test indicates to run hack/update-gofmt, however, after running hack/update-gofmt & ack/verify-gofmt this makes not formatting changes

wenyizha@3c22fb3758da aws-efs-csi-driver % hack/verify-gofmt 
Verifying gofmt
No issue found

wenyizha@3c22fb3758da aws-efs-csi-driver % hack/update-gofmt 
wenyizha@3c22fb3758da aws-efs-csi-driver % git status        
On branch DocUpdate
Your branch is up to date with 'origin/DocUpdate'.

nothing to commit, working tree clean

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2022
@wongma7
Copy link
Contributor

wongma7 commented Aug 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 36859e7 into kubernetes-sigs:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants