Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release-1.4 : post-release files updated #782

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Release-1.4 : post-release files updated #782

merged 1 commit into from
Oct 11, 2022

Conversation

mskanth972
Copy link
Contributor

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mskanth972
Once this PR has been reviewed and has the lgtm label, please assign ashley-wenyizha for approval by writing /assign @ashley-wenyizha in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @mskanth972. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2022
@Ashley-wenyizha
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2022
Ashley-wenyizha
Ashley-wenyizha reviewed Oct 7, 2022
View reviewed changes
charts/aws-efs-csi-driver/Chart.yaml Outdated
@@ -1,7 +1,7 @@
apiVersion: v2
name: aws-efs-csi-driver
version: 2.2.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump up helm chart version here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@mskanth972 mskanth972 changed the title EFS-54452 : post-release files updated Release-1.4 : post-release files updated Oct 8, 2022
Ashley-wenyizha
Ashley-wenyizha reviewed Oct 10, 2022
View reviewed changes
charts/aws-efs-csi-driver/Chart.yaml
@@ -1,7 +1,7 @@
apiVersion: v2
name: aws-efs-csi-driver
version: 2.2.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 2.12.0?

@Ashley-wenyizha
Copy link
Contributor

Please squash the commits and only keep one commit

@Ashley-wenyizha
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@Ashley-wenyizha
Copy link
Contributor

/approved

@Ashley-wenyizha
Copy link
Contributor

approved

@Ashley-wenyizha Ashley-wenyizha merged commit ecde544 into kubernetes-sigs:release-1.4 Oct 11, 2022
@mskanth972 mskanth972 mentioned this pull request Jan 25, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashley-wenyizha Ashley-wenyizha Ashley-wenyizha left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@Ashley-wenyizha Ashley-wenyizha

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mskanth972 @k8s-ci-robot @Ashley-wenyizha