Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New image based on minimal EKS Distro images #903

Merged
merged 1 commit into from
Feb 7, 2023
Merged

New image based on minimal EKS Distro images #903

merged 1 commit into from
Feb 7, 2023

Conversation

RyanStan
Copy link
Contributor

@RyanStan RyanStan commented Feb 3, 2023

Use EKS-Distro minimal python images to build a minimal image. This will improve the security posture of this image by reducing the number of unused packaged that were previously bundled in as part of the amazon linux base image we were using.

Also, I bumped up the yum install version to 1.34.4 since this version is available in the AL repos.

What testing is done?
E2E tests with new image.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @RyanStan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2023
@Ashley-wenyizha
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2023
@RyanStan
Copy link
Contributor Author

RyanStan commented Feb 3, 2023

/retest

@RyanStan RyanStan force-pushed the minimal-image branch 2 times, most recently from a8ffa75 to 08cbb9c Compare February 6, 2023 19:28
@RyanStan
Copy link
Contributor Author

RyanStan commented Feb 6, 2023

/retest

@RyanStan
New image based on minimal EKS Distro images
2fe263f 
Use EKS-Distro minimal python images to build a minimal image.  This
will improve the security posture of this image by reducing the number of
unused packaged that were previously bundled in as part of the amazon linux base image we were using.
@RyanStan
Copy link
Contributor Author

RyanStan commented Feb 6, 2023

/retest

1 similar comment
@RyanStan
Copy link
Contributor Author

RyanStan commented Feb 6, 2023

/retest

@Ashley-wenyizha
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@Ashley-wenyizha
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ashley-wenyizha, RyanStan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 193bb97 into kubernetes-sigs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@Ashley-wenyizha Ashley-wenyizha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanStan @k8s-ci-robot @Ashley-wenyizha