Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to aws-sdk-go-v2 as v1 is going away #736

Open
dims opened this issue Jul 26, 2024 · 3 comments · May be fixed by #754
Open

switch to aws-sdk-go-v2 as v1 is going away #736

dims opened this issue Jul 26, 2024 · 3 comments · May be fixed by #754

Comments

@dims
Copy link
Member

dims commented Jul 26, 2024

Context: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
Migration guide: https://aws.github.io/aws-sdk-go-v2/docs/migrating/

Basically maintenance mode on July 31, 2024 and reach end-of-support on July 31, 2025. The SDK will not
receive API updates for new or existing services, or be updated to support new regions.

@bored-engineer
Copy link

For folks that are only using this package to generate client-side tokens (i.e. github.com/kubernetes-sigs/aws-iam-authenticator/pkg/token), I have published a small Golang package that uses the AWS v2 SDK instead: https://github.com/bored-engineer/aws-eks-auth

@dims
Copy link
Member Author

dims commented Aug 10, 2024

cc @prateekgogia @kmala

@micahhausler
Copy link
Member

micahhausler commented Aug 30, 2024

In working on the V2 upgrade, one key difference is that the new SDK does not expose the internal list of known endpoints for a particular partition.

The current behavior is that the server builds up a list of known regions from SDK v1 for a given partition (specified via a server flag), and ensures that the domain of incoming pre-signed requests is one of those known endpoints. The reason we don't want to allow cross-partition STS tokens, is that AWS treats partitions (aws, aws-cn, aws-us-gov, etc) as fully isolated fault and trust domains. The tradeoff we currently make is that a new region requires an SDK update to aws-iam-authenticator. Given that we no longer can get this list of STS endpoints, I'll need to add new functionality for region discovery.

Similar to how we support multiple backend mappers for ARN to username discovery, I'll start out with region discovery in the following formats:

  • SDK v1 based (deprecated)
  • account:ListRegions based discovery (with some periodic cache update). This will have the tradeoff with this approach is necessitating code changes if new TLDs or URL formats are used (ex .api.aws for dualstack on aws partition, service-fips.region.tld for FIPS, etc) or new partitions are created (Infrequent, but at least one is public)
  • File based input. EKS will likely use this and seed it with an internally generated list of endpoints.

We'll default to SDKv1 based behavior to preserve backward compatibility, and likely drop support around the time SDKv1 reaches end of life on July 31, 2025. At that point, we'll change the default to account:ListRegions.

Given this change can be independent of the SDK upgrade, I'll make a separate PR that will be mergable prior to an SDK upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants