Add configurable Now time for signature generation #741
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: micahhausler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
micahhausler
force-pushed
the
token-signing-time
branch
2 times, most recently
from
97f0c58 to
45e56cc
Compare
This behavior and test is prep for an AWS SDK update, to ensure that the generated token (signature) matches when we update the SDK. Signed-off-by: Micah Hausler <mhausler@amazon.com>
micahhausler
force-pushed
the
token-signing-time
branch
from
45e56cc to
8a57c73
Compare
|
/lgtm |
|
@modulitos: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| Token: "k8s-aws-v1.aHR0cHM6Ly9zdHMudXMtd2VzdC0yLmFtYXpvbmF3cy5jb20vP0FjdGlvbj1HZXRDYWxsZXJJZGVudGl0eSZWZXJzaW9uPTIwMTEtMDYtMTUmWC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BU0lBUjJURzQ0VjZBUzNaWkU3QyUyRjIwMjMwNDI4JTJGdXMtd2VzdC0yJTJGc3RzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyMzA0MjhUMDAwMDAwWiZYLUFtei1FeHBpcmVzPTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JTNCeC1rOHMtYXdzLWlkJlgtQW16LVNpZ25hdHVyZT00ZDdhYmZkZTk2NzI1ZWI4YTc3MzgyNDg0MTZlNGI1ZDA4ZDlkYmQ3MThiNGY2ZGQ2OTBmOGZiNzUwMTMyOWQ1", | ||
| Expiration: time.Unix(1682640000, 0).Local().Add(time.Minute * 14), | ||
| }, | ||
| nil, |
There was a problem hiding this comment.
do we need a test case that has an error?
There was a problem hiding this comment.
The only possible error is a request.Presign() error, which I'm not really concerned with for the purposes of this test
This behavior and test is prep for an AWS SDK update, to ensure that the generated token (signature) matches when we update the SDK.
What this PR does / why we need it:
Preparation for #736