Add errors types to Verify to differentiate between token and STS errors #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nckturner
approved these changes
Feb 16, 2018
pkg/token/token_test.go
Outdated
| if err == nil || !strings.Contains(err.Error(), expectedErr) { | ||
| t.Errorf("err should have contained '%s' was '%s'", expectedErr, err) | ||
| } | ||
| } | ||
|
|
||
| func isSTSError(t *testing.T, err error) { |
There was a problem hiding this comment.
Nit: I'd prefer validateSTSError or assertSTSError because you aren't returning a bool, your asserting and erroring on failure.
…ors. It is useful to track latency for cases where STS is called differently than when the token passed in does not meet the requirements. This splits the errors returned by token.Verify into two groups TokenFormatError and STSError to allow users to differentiate between the two. Signed-off-by: Matt Landis <matlan@amazon.com>
mattlandis
force-pushed
the
add-sts-error-metric
branch
from
855dec3 to
0375c9b
Compare
|
@nckturner updated name and rebased. |
joanayma
pushed a commit
to joanayma/aws-iam-authenticator
that referenced
this pull request
Aug 11, 2021
…abels Kubelet node labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to track latency for cases where STS is called differently
than when the token passed in does not meet the requirements. This
splits the errors returned by token.Verify into two groups
TokenFormatError and STSError to allow users to differentiate between
the two.
Signed-off-by: Matt Landis matlan@amazon.com