-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --log-format server flag to configure output format #73
Add --log-format server flag to configure output format #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine with me as is, but I'd prefer not to add the other dependency you mentioned. (Sorry about the long wait for feedback). You'll need to sign the linuxfoundation CLA now though, to get this merged since we moved to kubernetes-sigs.
Thanks for reviewing! You not wanting to add a new dependency for this is totally understandable, no problem for me dropping that idea. Pretty sure I got that CLA signed now, at least that's what I interpret from the verification email titled |
/lgtm |
Can you rebase @phillipj? |
These changes allows the logger format to be specified when starting the server, either to `text` (default) or `json`. Signed-off-by: Phillip Johnsen <johphi@gmail.com>
a889142
to
fb5a6de
Compare
Sure thing, rebased and force pushed -- conflicts were trivial enough that a 3-way merge did the trick. |
/lgtm |
These changes allows the logger format to be specified when starting the
server, either to
text
(default) orjson
.I'm also interested in adding support for the fluentd format, though that would mean adding a 3rd party dependency: https://github.com/joonix/log.
Any thoughts about the changes as is and/or possible new dependency?
Refs #52