-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the regression of IP mode support for fargate pods #2158
Conversation
5b19940
to
7c2c2ef
Compare
Codecov Report
@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
+ Coverage 52.04% 52.26% +0.21%
==========================================
Files 132 132
Lines 7130 7166 +36
==========================================
+ Hits 3711 3745 +34
- Misses 3131 3132 +1
- Partials 288 289 +1
Continue to review full report at Codecov.
|
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/unhold |
cherry-pick into release-2.2: fix the regression of IP mode support for fargate pods (#2158)
cherry-pick into release-2.2: fix the regression of IP mode support for fargate pods (kubernetes-sigs#2158)
Issue
#2156
Description
Fix the regression of IP mode support for Fargate pods introduced by #2137.
These Fargate pod's ENI have to be resolved via VPC IPAddress.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯