Restrict iam policy by tagging SG rules and shield protection #3799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, the controller does not tag SG rules or shield protection, and the IAM policy is allowing corresponding actions on all resources, which may lead to security concern.
Description
This PR adds the support for the controller to tag SG rules and shield protection, so that we can further scope down the corresponding IAM policies by tags. This PR also introduces new IAM policies for
shield:TagResource
onprotection
resource andec2:CreateTags
onsecurity-group-rule
resource.manual test
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯