IPv6 Support in Inbound CIDR Annotation

[csnitker]

1. Added support for IPv6 CIDR blocks in the inbound CIDRs annotation
2. Added default CIDR (::/0) when ip address type is set to dualstack

This fixes: #887

[k8s-ci-robot]

Welcome @csnitker!

It looks like this is your first PR to kubernetes-sigs/aws-alb-ingress-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-alb-ingress-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @csnitker. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csnitker]

/check-cla

[csnitker]

/assign @bigkraig

[csnitker]

@M00nF1sh or @micahhausler - Any chance I could get a review and an ok for testing?

[M00nF1sh]

/ok-to-test

[M00nF1sh]

ip.To4() is not enough, ip.To4() for "::/0" will return non-nil, and cause SG update fails.
Example checks in V2 branch: https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/v2/pkg/build/lb_security_group.go#L145

[M00nF1sh]

would we change the logic to align with V2: https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/v2/pkg/build/lb_security_group.go#L166
Basically only append v4/v6 default settings when customer haven't explicitly configured any cidrs.
If the customer only configured v6 cidr but didn't specify "dualstack", it's typically due an error(where customer expected only v6 works), and we shouldn't append default 0.0.0.0/0 in such case)

[M00nF1sh]

Thanks for making contributions :D left a few tiny comments :D

[csnitker]

/retest

[M00nF1sh]

/retest

[M00nF1sh]

/test pull-aws-alb-ingress-controller-e2e-test

[M00nF1sh]

@csnitker
Hi, would you help change sg/security_group.go as well, currently it doesn't support ipv6 permissions.
The e2e test is failing with below msg:

ingress-7696/multi-path-echo: granting inbound permissions to securityGroup sg-0a930ff60cad5318e: [{    FromPort: 80,    IpProtocol: "tcp",    IpRanges: [{        CidrIp: "0.0.0.0/0",        Description: "Allow ingress on port 80 from 0.0.0.0/0"      }],    Ipv6Ranges: [],    ToPort: 80  }]
E0816 23:07:36.507947       1 controller.go:217] kubebuilder/controller "msg"="Reconciler error" "error"="failed to reconcile securityGroup associations due to failed to reconcile managed LoadBalancer securityGroup due to failed to grant inbound permissions due to InvalidParameterValue: missing mandatory parameter: exactly one of remote-security-group, remote-ip-range, remote-ipv6-range, or prefix-list-id must be present\n\tstatus code: 400, request id: 9bc39a33-f294-43b2-a8a9-b807c5c35960"  "controller"="alb-ingress-controller" "request"={"Namespace":"ingress-7696","Name":"multi-path-echo"}

[M00nF1sh]

/retest

[M00nF1sh]

@csnitker
Looks like it's still failing..i'll update the e2e test case to have a timeout instead of forever wait...

As of now, I think the easiest fix is to add IpV4 and IpV6 as separate ec2.IpPermission Object(above the line of inboundPermissions = append(inboundPermissions, permission)) That's because ec2 expects each ec2.IpPermission contains either ipv4 or ipv6 permission.

Alternatively, we'll need to implement https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/f8556d824c158201ecbda09bf25c4dc2ae610896/pkg/deploy/lb_security_group.go#L279 in securityGroup.Reconcile.

[csnitker]

@M00nF1sh - Looks like that was the problem, the tests appear to be passing this time

[M00nF1sh]

Thanks a lot for the change :D
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csnitker, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [M00nF1sh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment