Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[warm up] write a few unit tests #1

Closed
andyzhangx opened this issue Jan 4, 2019 · 0 comments
Closed

[warm up] write a few unit tests #1

andyzhangx opened this issue Jan 4, 2019 · 0 comments

Comments

@andyzhangx
Copy link
Member

As a warm up, could you(@Masquerade0097 ) write a few unit tests first in this project:
getFileShareInfo, getStorageAccount under https://github.com/andyzhangx/azurefile-csi-driver/blob/master/pkg/azurefile/azurefile.go

You could refer to https://github.com/andyzhangx/azurefile-csi-driver/blob/master/pkg/azurefile/azurefile_test.go#L25-L67

Here is the development guide:
https://github.com/andyzhangx/azurefile-csi-driver/blob/master/docs/csi-dev.md
@Masquerade0097 Masquerade0097 mentioned this issue Jan 10, 2019
Merged
levimm pushed a commit to levimm/azurefile-csi-driver that referenced this issue Dec 25, 2019
@andyzhangx
Merge pull request kubernetes-sigs#1 from Masquerade0097/migrate
2641dda 
Confirm to Kubernetes repo requirements
dobsonj pushed a commit to dobsonj/azurefile-csi-driver that referenced this issue Feb 22, 2022
@jsafrane
Merge pull request kubernetes-sigs#1 from bertinatto/bootstrap
ee548a6 
Add files required for downstream builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyzhangx @Masquerade0097