Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update examples for mount permissions setting #2310

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

m-anyac
Copy link
Contributor

@m-anyac m-anyac commented Dec 29, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add comment for mount permission
Fix installation guide

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

chore: add comment for mount permission and fix installation guide

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 29, 2024
@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied December 29, 2024 00:59
@k8s-ci-robot
Copy link
Contributor

Welcome @m-anyac!

It looks like this is your first PR to kubernetes-sigs/azurefile-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azurefile-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 29, 2024
Copy link

linux-foundation-easycla bot commented Dec 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Hi @m-anyac. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 29, 2024
@nearora-msft
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025
@m-anyac m-anyac changed the title feat: set default mount permissions for SMB to 0775 fix: Update examples for mount permissions of directory and file to 0775 Jan 7, 2025
@m-anyac m-anyac changed the title fix: Update examples for mount permissions of directory and file to 0775 fix: Update examples for mount permissions to 0775 Jan 7, 2025
@m-anyac
Copy link
Contributor Author

m-anyac commented Jan 7, 2025

Hi Andy @andyzhangx, could I get review from you?

I think I have no permission to add a reviewer to this PR.
Screenshot 2025-01-06 185128

@andyzhangx
Copy link
Member

@m-anyac
if you want to make more secure, then why not use 0755 ? and I don't think you need to change all examples, you only need to add a comment after 0777, e.g. 0777 # modify this permission if you want to enhance the security

@nearora-msft
Copy link
Contributor

@m-anyac if you want to make more secure, then why not use 0755 ? and I don't think you need to change all examples, you only need to add a comment after 0777, e.g. 0777 # modify this permission if you want to enhance the security

@andyzhangx Isn't a customer is more likely to use the example directly, instead of modifying the example based on comments? If we want this setting to be default in the future, it makes sense to modify the examples first?

@andyzhangx
Copy link
Member

@m-anyac if you want to make more secure, then why not use 0755 ? and I don't think you need to change all examples, you only need to add a comment after 0777, e.g. 0777 # modify this permission if you want to enhance the security

@andyzhangx Isn't a customer is more likely to use the example directly, instead of modifying the example based on comments? If we want this setting to be default in the future, it makes sense to modify the examples first?

@nearora-msft different customers want different settings, in the before, we have set as 0755 by default in the code, and then challenged by quite a lot customers since default setting won't work for them, and finally we reverted to 0777. I think we should set 0777 for general usage, and if specific customers wants to be more secure, then they could use 0775 or 0755, there is no setting applied for all customers, that's not possible.

@m-anyac m-anyac force-pushed the add-default-mountoptions branch from 1fc31d6 to 7d952b6 Compare January 9, 2025 01:29
@andyzhangx andyzhangx changed the title fix: Update examples for mount permissions to 0775 doc: Update examples for mount permissions setting Jan 9, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, m-anyac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@m-anyac
Copy link
Contributor Author

m-anyac commented Jan 9, 2025

/easycla

@m-anyac
Copy link
Contributor Author

m-anyac commented Jan 9, 2025

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@andyzhangx
Copy link
Member

Ubuntu apt update is down, so this failure is expected now:

7.898 Processing triggers for libc-bin (2.36-9+deb12u8) ...
7.913 Processing triggers for ca-certificates (20230311) ...
7.919 Updating certificates in /etc/ssl/certs...
8.736 0 added, 0 removed; done.
8.736 Running hooks in /etc/ca-certificates/update.d...
8.738 done.
9.091 
9.091 gzip: stdin: not in gzip format
9.092 tar: Child returned status 1
9.092 tar: Error is not recoverable: exiting now

@andyzhangx
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@m-anyac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-capz 7a1c5c5 link true /test pull-azurefile-csi-driver-e2e-capz
pull-azurefile-csi-driver-e2e-migration-windows 7a1c5c5 link true /test pull-azurefile-csi-driver-e2e-migration-windows
pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess 7a1c5c5 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess
pull-azurefile-csi-driver-external-e2e-smb 7a1c5c5 link true /test pull-azurefile-csi-driver-external-e2e-smb
pull-azurefile-csi-driver-e2e-migration 7a1c5c5 link true /test pull-azurefile-csi-driver-e2e-migration
pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess 7a1c5c5 link true /test pull-azurefile-csi-driver-e2e-capz-windows-2019-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 9d85a77 into kubernetes-sigs:master Jan 10, 2025
13 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants