-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Update examples for mount permissions setting #2310
doc: Update examples for mount permissions setting #2310
Conversation
Welcome @m-anyac! |
Hi @m-anyac. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Hi Andy @andyzhangx, could I get review from you? |
@m-anyac |
@andyzhangx Isn't a customer is more likely to use the example directly, instead of modifying the example based on comments? If we want this setting to be default in the future, it makes sense to modify the examples first? |
@nearora-msft different customers want different settings, in the before, we have set as 0755 by default in the code, and then challenged by quite a lot customers since default setting won't work for them, and finally we reverted to 0777. I think we should set 0777 for general usage, and if specific customers wants to be more secure, then they could use 0775 or 0755, there is no setting applied for all customers, that's not possible. |
1fc31d6
to
7d952b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, m-anyac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/easycla |
/retest |
New changes are detected. LGTM label has been removed. |
Ubuntu apt update is down, so this failure is expected now:
|
/retest |
@m-anyac: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add comment for mount permission
Fix installation guide
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: