-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add DisableAzureStackCloud to customize arm endpoint #2351
Conversation
Skipping CI for Draft Pull Request. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the real fix in this PR? I did not see this PR touches DisableAzureStackCloud.
@MartinForReal
I think master branch already has this fix in last track2 sdk upgrade for this CSI driver. but release-1.31 is broken |
What type of PR is this?
/kind bug
What this PR does / why we need it:
bump cloud provider to add DisableAzureStackCloud to customize arm endpoint
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: