Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use workload identity for e2e test #1551

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Aug 19, 2024

What type of PR is this?
/kind test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

test: use wi for e2e test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 19, 2024
@cvvz
Copy link
Member Author

cvvz commented Aug 19, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 19, 2024
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

this test code also needs to be changed:

// assign role to service principal
objectID, err := kvClient.GetServicePrincipalObjectID(ctx, kvClient.Cred.AADClientID)
framework.ExpectNoError(err, fmt.Sprintf("Error GetServicePrincipalObjectID from clientID(%s): %v", kvClient.Cred.AADClientID, err))
resourceID := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Storage/storageAccounts/%s", kvClient.Cred.SubscriptionID, kvClient.Cred.ResourceGroup, accountName)
ginkgo.By(fmt.Sprintf("assign Storage Blob Data Contributor role to the service principal, objectID:%s", objectID))
roleDef, err := authClient.GetRoleDefinition(ctx, resourceID, "Storage Blob Data Contributor")

@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/test pull-blob-csi-driver-e2e

1 similar comment
@andyzhangx
Copy link
Member

/test pull-blob-csi-driver-e2e

@umagnus umagnus mentioned this pull request Aug 29, 2024
4 tasks
@andyzhangx
Copy link
Member

/test pull-blob-csi-driver-e2e-proxy

@cvvz cvvz force-pushed the use-wi-for-e2e-test branch from 51bb2d8 to 870dc9c Compare August 29, 2024 08:00
@andyzhangx andyzhangx force-pushed the use-wi-for-e2e-test branch from e91009e to c8798c0 Compare August 29, 2024 11:57
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@andyzhangx andyzhangx merged commit 46035f8 into kubernetes-sigs:master Aug 29, 2024
20 of 22 checks passed
@andyzhangx
Copy link
Member

/cherrypick release-1.30

@andyzhangx
Copy link
Member

/cherrypick release-1.29

@andyzhangx
Copy link
Member

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@andyzhangx: cannot checkout release-1.30: error checking out "release-1.30": exit status 1 error: pathspec 'release-1.30' did not match any file(s) known to git

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: cannot checkout release-1.29: error checking out "release-1.29": exit status 1 error: pathspec 'release-1.29' did not match any file(s) known to git

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: cannot checkout release-1.28: error checking out "release-1.28": exit status 1 error: pathspec 'release-1.28' did not match any file(s) known to git

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andyzhangx
Copy link
Member

/cherrypick release-1.24

@andyzhangx
Copy link
Member

/cherrypick release-1.23

@andyzhangx
Copy link
Member

/cherrypick release-1.22

@k8s-infra-cherrypick-robot

@andyzhangx: #1551 failed to apply on top of branch "release-1.24":

Applying: test: use wi for e2e test
error: patch failed: vendor/github.com/pelletier/go-toml/example-crlf.toml:1
error: vendor/github.com/pelletier/go-toml/example-crlf.toml: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Patch failed at 0001 test: use wi for e2e test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #1551 failed to apply on top of branch "release-1.23":

Applying: test: use wi for e2e test
error: patch failed: vendor/github.com/pelletier/go-toml/example-crlf.toml:1
error: vendor/github.com/pelletier/go-toml/example-crlf.toml: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	pkg/util/util.go
M	test/e2e/suite_test.go
M	vendor/modules.txt
Patch failed at 0001 test: use wi for e2e test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #1551 failed to apply on top of branch "release-1.22":

Applying: test: use wi for e2e test
error: patch failed: vendor/github.com/pelletier/go-toml/example-crlf.toml:1
error: vendor/github.com/pelletier/go-toml/example-crlf.toml: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	pkg/util/util.go
M	test/e2e/suite_test.go
M	test/sanity/run-test.sh
M	test/utils/azure/azure_helper.go
M	vendor/modules.txt
Patch failed at 0001 test: use wi for e2e test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andyzhangx andyzhangx changed the title test: use wi for e2e test test: use workload identity for e2e test Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants