Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Deprecated labels from cloud-node-manager #2653

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Removed Deprecated labels from cloud-node-manager #2653

merged 1 commit into from
Nov 4, 2022

Conversation

Bryce-Soghigian
Copy link
Member

What type of PR is this?

Cleanup PR

What this PR does / why we need it:

This is a PR to remove the deprecated labels and the tests testing those deprecated labels.

Which issue(s) this PR fixes:

Fixes #2453

Special notes for your reviewer:

I am wondering if we want to remove the label reconciler too since its functionality depended on those labels? or we can keep it for future labels we might want to attach to the nodes.

Does this PR introduce a user-facing change?

The following labels are removed on the nodes:
* "failure-domain.beta.kubernetes.io/zone" 
* "failure-domain.beta.kubernetes.io/region"
* "beta.kubernetes.io/instance-type"

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 28, 2022
@netlify
Copy link

netlify bot commented Oct 28, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 67c2407
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/635c3f6c8c32350008d4f82a

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Oct 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Bryce-Soghigian. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 28, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2022
Removed Deprecated labels from cloud-node-manager
67c2407 
removing deprecated labels from nodemanager.go

removed tests surrounding the deprecated labels

chore(deps): bump k8s.io/api from 0.25.2 to 0.25.3

Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.25.2 to 0.25.3.
- [Release notes](https://github.com/kubernetes/api/releases)
- [Commits](kubernetes/api@v0.25.2...v0.25.3)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump k8s.io/client-go from 0.25.2 to 0.25.3

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.25.2 to 0.25.3.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.25.2...v0.25.3)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump k8s.io/component-base from 0.25.2 to 0.25.3

Bumps [k8s.io/component-base](https://github.com/kubernetes/component-base) from 0.25.2 to 0.25.3.
- [Release notes](https://github.com/kubernetes/component-base/releases)
- [Commits](kubernetes/component-base@v0.25.2...v0.25.3)

---
updated-dependencies:
- dependency-name: k8s.io/component-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Verify and update vendor licenses
* Add verify-azure-vendor-licenses.sh update-azure-vendor-licenses.sh
* Add Makefile targets
* Add verify-vendor-licenses to check job
* Add vendor licenses

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>

test: add codespell github action

doc: fix spelling issues

fix

doc: fix code spelling

fix

chore(deps): bump k8s.io/controller-manager from 0.25.2 to 0.25.3

Bumps [k8s.io/controller-manager](https://github.com/kubernetes/controller-manager) from 0.25.2 to 0.25.3.
- [Release notes](https://github.com/kubernetes/controller-manager/releases)
- [Commits](kubernetes/controller-manager@v0.25.2...v0.25.3)

---
updated-dependencies:
- dependency-name: k8s.io/controller-manager
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump k8s.io/cloud-provider from 0.25.2 to 0.25.3

Bumps [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) from 0.25.2 to 0.25.3.
- [Release notes](https://github.com/kubernetes/cloud-provider/releases)
- [Commits](kubernetes/cloud-provider@v0.25.2...v0.25.3)

---
updated-dependencies:
- dependency-name: k8s.io/cloud-provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump github.com/fsnotify/fsnotify from 1.5.4 to 1.6.0

Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.5.4 to 1.6.0.
- [Release notes](https://github.com/fsnotify/fsnotify/releases)
- [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md)
- [Commits](fsnotify/fsnotify@v1.5.4...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/fsnotify/fsnotify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

[e2e] Should clean up pip in azure-load-balancer-ip annotation test

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>

chore(deps): bump k8s.io/kubelet from 0.25.2 to 0.25.3

Bumps [k8s.io/kubelet](https://github.com/kubernetes/kubelet) from 0.25.2 to 0.25.3.
- [Release notes](https://github.com/kubernetes/kubelet/releases)
- [Commits](kubernetes/kubelet@v0.25.2...v0.25.3)

---
updated-dependencies:
- dependency-name: k8s.io/kubelet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump golang.org/x/text from 0.3.8 to 0.4.0

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.8 to 0.4.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.3.8...v0.4.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Adjust e2e tests
* Can avoid printing stdout and stderr when run kubectl
* Service CIDR is hardcoded to IPv4 for AKS pipeline

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>

update go version params of github action

Signed-off-by: MartinForReal <fanshangxiang@gmail.com>

Update release notes for v1.24.9

Update release notes for v1.25.3

add label for release notes pr

Update release notes for v1.23.22

Update release notes for v1.1.25

VMSS Flex Support: Add a new vmType for pure VMSS Flex cluster to bypass the node type check

added back stable labels

removing apostrophe

chore(deps): bump golang.org/x/text from 0.3.8 to 0.4.0

Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.8 to 0.4.0.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.3.8...v0.4.0)

---
updated-dependencies:
- dependency-name: golang.org/x/text
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Adjust e2e tests
* Can avoid printing stdout and stderr when run kubectl
* Service CIDR is hardcoded to IPv4 for AKS pipeline

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>

update go version params of github action

Signed-off-by: MartinForReal <fanshangxiang@gmail.com>

Update release notes for v1.24.9

Update release notes for v1.25.3

add label for release notes pr

Update release notes for v1.23.22

Update release notes for v1.1.25

VMSS Flex Support: Add a new vmType for pure VMSS Flex cluster to bypass the node type check

fix: avoid recreate vmss cache in race condition

feat: use singleflight.Group instead of lock to fix race condition

doc: fix spelling error

chore(deps): bump actions/checkout from 2 to 3

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump github.com/stretchr/testify from 1.8.0 to 1.8.1

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.0...v1.8.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.4.0

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

switch azurefile snanshot to management api

return FileShare in CreateSnapshot

use fileshare instead of snapshot

fix unittest

add ListFileShare function

 add comment

change ListFileShare function

chore: describe and get pod log when it is failed

Refactor e2e and print more Pod info if unexpected error

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>

VMSS Flex Support: add VMSS Flex related contents to Cloud-Provider-Azure Docs

VMSS Flex Support: add VMSS Flex related contents to Cloud-Provider-Azure Docs

VMSS Flex Support: add VMSS Flex related contents to Cloud-Provider-Azure Docs

VMSS Flex Support: add VMSS Flex related contents to Cloud-Provider-Azure Docs

VMSS Flex Support: add VMSS Flex related contents to Cloud-Provider-Azure Docs

VMSS Flex Support: add VMSS Flex related contents to Cloud-Provider-Azure Docs

add more explanation docs

chore(deps): bump github.com/spf13/cobra from 1.6.0 to 1.6.1

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.6.0...v1.6.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

bump compute version to 2022-03-01

update helm chart to 1.25.3

remove kubeversion because semver doesn't recognise v1.24.8-rc.0.15+310b6ffb01918a

chore(deps): bump github.com/onsi/gomega from 1.22.1 to 1.23.0

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.22.1 to 1.23.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.22.1...v1.23.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

modified license

removed thing
@Bryce-Soghigian
Copy link
Member Author

I accidentally closed the previous one see comments on this #2559

@Bryce-Soghigian
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind labels Oct 28, 2022
@Bryce-Soghigian
Copy link
Member Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@Bryce-Soghigian: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 79.761% when pulling 67c2407 on Bryce-Soghigian:removing-deprecated-labels into b6bdfb1 on kubernetes-sigs:master.

@Bryce-Soghigian
Copy link
Member Author

/retest-required

@nilo19
Copy link
Contributor

nilo19 commented Oct 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2022
feiskyer
feiskyer reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bryce-Soghigian, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 95e8db9 into kubernetes-sigs:master Nov 4, 2022
@JoelSpeed JoelSpeed mentioned this pull request Apr 3, 2023
Merged
christinalau0 added a commit to christinalau0/aks-engine-azurestack that referenced this pull request Jul 12, 2023
@christinalau0
chore: support Kubernetes v1.26.6
b4a12e9 
- add k8s v1.26.6
- add azure-cloud-controller-manager and azure-cloud-node-manager v1.26.10
- noteable change in azure-cloud-node-manager: [removed deprecated labels](kubernetes-sigs/cloud-provider-azure#2653)
- bumped all test workflow k8s versions
christinalau0 added a commit to christinalau0/aks-engine-azurestack that referenced this pull request Jul 12, 2023
@christinalau0
chore: support Kubernetes v1.26.6
d039f9d 
- add k8s v1.26.6
- add azure-cloud-controller-manager and azure-cloud-node-manager v1.26.10
- noteable change in azure-cloud-node-manager: [removed deprecated labels](kubernetes-sigs/cloud-provider-azure#2653)
- bumped all test workflow k8s versions
@christinalau0 christinalau0 mentioned this pull request Jul 13, 2023
Merged
8 tasks
This was referenced Aug 4, 2023
Closed
Closed
Merged
@Bryce-Soghigian Bryce-Soghigian mentioned this pull request Jan 4, 2024
Closed
9 tasks
@kon-angelo kon-angelo mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bryce-Soghigian @k8s-ci-robot @feiskyer @coveralls @nilo19