Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.26] fix: allow space separated load balancer source ranges #5895

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jwtty
Copy link
Member

@jwtty jwtty commented Apr 10, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

cherry pick #5885

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow space-separated load balancer source ranges in service annotation. Allow `service.beta.kubernetes.io/load-balancer-source-ranges` to be used together with `service.beta.kubernetes.io/azure-allowed-service-tags`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2024
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@lzhecheng
Copy link
Contributor

/test cloud-provider-azure-master-ipv6-capz-1-26
/test cloud-provider-azure-master-ipv6-vmss-capz-1-26

@k8s-ci-robot
Copy link
Contributor

@lzhecheng: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cloud-provider-azure-check-1-26
  • /test pull-cloud-provider-azure-e2e-capz-1-26
  • /test pull-cloud-provider-azure-e2e-ccm-capz-1-26
  • /test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26
  • /test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26
  • /test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-26
  • /test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz-1-26
  • /test pull-cloud-provider-azure-unit-1-26

Use /test all to run the following jobs that were automatically triggered:

  • pull-cloud-provider-azure-check-1-26
  • pull-cloud-provider-azure-e2e-capz-1-26
  • pull-cloud-provider-azure-e2e-ccm-capz-1-26
  • pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-26
  • pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz-1-26
  • pull-cloud-provider-azure-unit-1-26

In response to this:

/test cloud-provider-azure-master-ipv6-capz-1-26
/test cloud-provider-azure-master-ipv6-vmss-capz-1-26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26
/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26

@k8s-ci-robot k8s-ci-robot merged commit 8a9371b into kubernetes-sigs:release-1.26 Apr 10, 2024
15 checks passed
@jwtty jwtty deleted the cp-range-1.26 branch April 10, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants