fix: revert to go1.22 windows filesystem stdlib behavior building with go 1.23 #7750
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cherrypick release-1.31 |
|
/cherrypick release-1.30 |
|
/cherrypick release-1.29 |
|
@andyzhangx: new pull request created: #7751 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andyzhangx: new pull request created: #7752 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andyzhangx: new pull request created: #7753 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -2,6 +2,10 @@ module sigs.k8s.io/cloud-provider-azure | |||
|
|
|||
| go 1.23.1 | |||
|
|
|||
| godebug winreadlinkvolume=0 | |||
There was a problem hiding this comment.
note that we may just be setting the winsymlink option in 1.32 in Kubernetes, see discussion in kubernetes/kubernetes#129103
There was a problem hiding this comment.
thanks, fixed by #7771
What type of PR is this?
/kind bug
What this PR does / why we need it:
Revert to go 1.22 windows filesystem behavior building with go 1.23 until use of Stat/Lstat/EvalSymlinks adjusts to go1.23 behavior
for more details, refer to kubernetes/kubernetes#129080
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: