Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate slb/pip/vm/vmss/vmas to track2 sdk #7833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

migrate slb/pip/vm/vmss/vmas to track2 sdk #7833

wants to merge 1 commit into from

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Dec 13, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

migrate slb/pip/vm/vmss/vmas to track2 sdk

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2024
@MartinForReal MartinForReal force-pushed the shafan/compute branch 4 times, most recently from 80144d4 to 9c837ae Compare December 15, 2024 05:37
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2024
@MartinForReal MartinForReal force-pushed the shafan/compute branch 2 times, most recently from a731968 to fcd2452 Compare December 15, 2024 06:21
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2024
@MartinForReal MartinForReal marked this pull request as ready for review December 15, 2024 06:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2024
@MartinForReal MartinForReal force-pushed the shafan/compute branch 5 times, most recently from 1a171f4 to 83d6739 Compare December 17, 2024 06:49
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 17, 2024
@MartinForReal
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind labels Dec 17, 2024
@MartinForReal MartinForReal force-pushed the shafan/compute branch 4 times, most recently from 1f9ff81 to 85b9f7a Compare December 17, 2024 09:58
@MartinForReal
Copy link
Contributor Author

/retest

1 similar comment
@MartinForReal
Copy link
Contributor Author

/retest

Copilot
Copilot AI reviewed Dec 18, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 321 out of 336 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • go.mod: Language not supported
  • pkg/azureclients/azure_client_config.go: Evaluated as low risk
  • pkg/azureclients/interfaceclient/doc.go: Evaluated as low risk
  • pkg/azureclients/azure_client_config_test.go: Evaluated as low risk
  • pkg/azureclients/armauth/token_provider.go: Evaluated as low risk
  • pkg/azureclients/armclient/doc.go: Evaluated as low risk
  • pkg/azureclients/armclient/interface.go: Evaluated as low risk
  • pkg/azureclients/armclient/mockarmclient/doc.go: Evaluated as low risk
  • pkg/azureclients/armclient/util.go: Evaluated as low risk
  • pkg/azureclients/armauth/multi_tenant_token_provider.go: Evaluated as low risk
  • pkg/azureclients/interfaceclient/azure_interfaceclient_test.go: Evaluated as low risk
  • pkg/azureclients/diskclient/doc.go: Evaluated as low risk
  • pkg/azureclients/diskclient/azure_diskclient_test.go: Evaluated as low risk
  • pkg/azureclients/diskclient/interface.go: Evaluated as low risk
  • pkg/azureclients/diskclient/mockdiskclient/doc.go: Evaluated as low risk
@andyzhangx
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

@MartinForReal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-vmssflex-capz 85b9f7a link true /test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MartinForReal
migrate slb/pip/subnet/vm/vmss/vmas to track2 sdk
a887d97 
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinForReal @k8s-ci-robot @andyzhangx