-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump go version to v1.21 #380
Conversation
@Fedosin 👋🏼, CAPI v1.6.X does not use go 1.21 AFAICT https://github.com/kubernetes-sigs/cluster-api/blob/v1.6.0/.golangci.yml#L3, the PR you linked merged into 1.7 milestone |
@furkatgofurov7 right, in v1.6 they are still on golang v1.20. there is no need to merge this pr right now |
/hold |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold cancel |
/test pull-cluster-api-operator-test-main |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 34a251faa30c3cb1ce43e833c90bd578e6a67e29
|
What this PR does / why we need it:
CAPI uses golang v1.21: kubernetes-sigs/cluster-api#9900. We need to do the same.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #