✨ Implement "upgrade plan" support #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold |
k8s-ci-robot
added
do-not-merge/hold
Fedosin
force-pushed
the
plugin_upgrade_plan
branch
2 times, most recently
from
c2bf71a to
731f8c8
Compare
Fedosin
force-pushed
the
plugin_upgrade_plan
branch
from
731f8c8 to
828e437
Compare
k8s-ci-robot
added
size/XL
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| @@ -375,100 +372,6 @@ func generateCAPIOperatorDeployment(name, namespace string) *appsv1.Deployment { | |||
| } | |||
| } | |||
There was a problem hiding this comment.
One question - this test removed, is it covered by upgrade plan tests? Shouldn't we leave both for clarity?
Comment on lines
+148
to
+159
| g.Eventually(func() (bool, error) { | ||
| provider, err := getGenericProvider(ctx, env, string(util.ClusterctlProviderType(genericProvider)), genericProvider.GetName(), genericProvider.GetNamespace()) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| if provider.GetSpec().FetchConfig == nil || provider.GetSpec().FetchConfig.URL != tt.customURL { | ||
| return false, nil | ||
| } | ||
|
|
||
| return true, nil | ||
| }, waitShort).Should(BeTrue()) |
There was a problem hiding this comment.
This format makes things a bit more tidy IMO.
Suggested change
| g.Eventually(func() (bool, error) { | |
| provider, err := getGenericProvider(ctx, env, string(util.ClusterctlProviderType(genericProvider)), genericProvider.GetName(), genericProvider.GetNamespace()) | |
| if err != nil { | |
| return false, err | |
| } | |
| if provider.GetSpec().FetchConfig == nil || provider.GetSpec().FetchConfig.URL != tt.customURL { | |
| return false, nil | |
| } | |
| return true, nil | |
| }, waitShort).Should(BeTrue()) | |
| g.Eventually(func(g g.Gomega) error { | |
| provider, err := getGenericProvider(ctx, env, string(util.ClusterctlProviderType(genericProvider)), genericProvider.GetName(), genericProvider.GetNamespace()) | |
| g.Expect(err).ToNot(HaveOccurred()) | |
| g.Expect(provider.GetSpec().FetchConfig != nil && provider.GetSpec().FetchConfig.URL == tt.customURL).To(BeTrue()) | |
| }, waitShort).Should(Succeed()) |
|
/area plugin |
k8s-ci-robot
added
the
area/plugin
Fedosin
force-pushed
the
plugin_upgrade_plan
branch
from
8c8298b to
0c92b56
Compare
k8s-ci-robot
added
the
needs-rebase
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fedosin
force-pushed
the
plugin_upgrade_plan
branch
from
0c92b56 to
ac389d7
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
There was a problem hiding this comment.
/lgtm
/hold
To give time to resolve comments from @Danil-Grigorev
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e3e00b12399b678b886855d9eb15b1a05140853c
|
This test overwrites exiting CRDs with older versions, which breaks futher tests.
Fedosin
force-pushed
the
plugin_upgrade_plan
branch
from
ac389d7 to
7e6e7eb
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm Will leave hold in case Mike wants to re-add removed test, otherwise everything looks good. Thanks! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d5797ef9378eaa039619667879372b7ee70df2a3
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements
upgrade plansupport for the pluginWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #129