🐛 Plugin Init improvements #461
Conversation
Now we use "latest" tag, but due to recent clusterctl changes it forces to download metadata.yaml file which is not available for CAPI operator. Because of that installation fails with exceeded context deadline. To prevent this we specify a version when we create a repo object, and then pick the latest version from the list of all available versions.
k8s-ci-robot
added
area/plugin
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cmd/plugin/cmd/init.go
Outdated
| @@ -509,6 +513,9 @@ func createGenericProvider(ctx context.Context, client ctrlclient.Client, provid | |||
|
|
|||
| log.Info("Installing provider", "Type", provider.GetType(), "Name", name, "Version", version, "Namespace", namespace) | |||
|
|
|||
| // We have to add a short delay here to ensure that the webhooks are successfully started. | |||
| time.Sleep(time.Second * 5) | |||
There was a problem hiding this comment.
are we waiting for CAPI Operator deployment to run?
There was a problem hiding this comment.
yes, we are waiting for webhooks to start. Sometimes when we create provider CRs, they are not ready, and therefore init fails.
but I'm going to add retries instead of the sleep.
Provider creation might fail because webhooks are not initialized yet. To prevent this, we add retries.
Fedosin
force-pushed
the
plugin_improvements
branch
from
373502a to
a3d27be
Compare
k8s-ci-robot
added
size/L
|
We have run into this issue as well trying to install the operator and then immediately trying to create a |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 62f99005f4578d872bab0f471c32f5a321b66b11
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR contains two fixes for the plugin Init operation:
Get the latest operator version from the list of all available versions
Now we use "latest" tag, but due to recent clusterctl changes it forces to download metadata.yaml file which is not available for CAPI operator. Because of that installation fails with exceeded context deadline. To prevent this we specify a version when we create a repo object, and then pick the latest version from the list of all available versions.
Add a short delay before deploying providers
We have to add a short delay here to ensure that the webhooks are successfully started.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #436
/area plugin