Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.9] ✨ Ability to add provider specific featureGates with Helm #484

Merged
merged 4 commits into from
Apr 9, 2024
Merged

[release-0.9] ✨ Ability to add provider specific featureGates with Helm #484

merged 4 commits into from
Apr 9, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #448

/assign jackfrancis

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 8, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2024
@jackfrancis
Copy link
Contributor

@Danil-Grigorev @alexander-demicev are these helm changes as-is appropriate for a v0.9 patch release? I notice there isn't a version bumb that is included, but perhaps that is because no changes to the chart API (values, etc) and instead add'l behaviors.

Happy to do any additional work to get this into release-0.9 so I can advocate for a release.

Thanks!

alexander-demicev
alexander-demicev approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 119709db44392014ccf648f7059abc8725c2eead

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@alexander-demicev
Copy link
Contributor

@jackfrancis I approved this cherry-pick, we can make a patch release this week

@k8s-ci-robot k8s-ci-robot merged commit 4622794 into kubernetes-sigs:release-0.9 Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@jackfrancis jackfrancis

@alexander-demicev alexander-demicev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @jackfrancis @k8s-ci-robot @alexander-demicev @oprinmarius @zioproto