⚠️ remove cert-manager support from helm chart #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we have experimental support for Cert Manager installation in the chart. As part of this, we store Cert Manager CRDs in the "crds" folder. If you install the chart with Helm, everything works fine, resources are only installed if they don't exist in the cluster. But if we use Argo, we always install CRDs even if they already exist by overwriting them. Since we can't get around this limitation, we decided to remove Cert Manager support from the chart. We recommend using the clusterctl plugin for local development and testing that retains support for installing Cert Manager. In the case of the chart, users must manage Cert Manager installation themselves.
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/L
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d012f90b50faf6ae1ff729c7d8f1b2574552e184
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Right now we have experimental support for Cert Manager installation in the chart. As part of this, we store Cert Manager CRDs in the "crds" folder. If you install the chart with Helm, everything works fine, resources are only installed if they don't exist in the cluster. But if we use Argo, we always install CRDs even if they already exist by overwriting them. Since we can't get around this limitation, we decided to remove Cert Manager support from the chart.
We recommend using the clusterctl plugin for local development and testing that retains support for installing Cert Manager. In the case of the chart, users must manage Cert Manager installation themselves.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #