Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to controller-tools v0.9.2 #3531

Closed
Tracked by #3530
pydctw opened this issue Jun 15, 2022 · 6 comments
Closed
Tracked by #3530

Upgrade to controller-tools v0.9.2 #3531

pydctw opened this issue Jun 15, 2022 · 6 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pydctw
Copy link
Contributor

pydctw commented Jun 15, 2022

Upgrade to controller-tools version that includes @chrischdi's PR that allows setting listMapKey, listType at both type and field level. Needed for using Server Side Apply with AWSCluster SubnetSpec.

Note: feel free to retitle with a correct controller-tools version when it is released.
@k8s-ci-robot k8s-ci-robot added needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2022
@pydctw pydctw mentioned this issue Jun 15, 2022
Closed
9 tasks
@sedefsavas
Copy link
Contributor

/triage accepted
/priority important-soon

We can bump this dependency during cluster-api 1.2.0 bump as SSA will go into that release.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jun 15, 2022
@pydctw pydctw mentioned this issue Jun 16, 2022
Closed
4 tasks
@sedefsavas
Copy link
Contributor

Related PR in cluster api: kubernetes-sigs/cluster-api#6542

@pydctw pydctw changed the title Upgrade to controller-tools v0.9.x Upgrade to controller-tools v0.9.2 Jul 12, 2022
@pydctw pydctw mentioned this issue Jul 12, 2022
Closed
4 tasks
@pydctw
Copy link
Contributor Author

pydctw commented Jul 12, 2022

/assign

@pydctw
Copy link
Contributor Author

pydctw commented Jul 22, 2022

/unassign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Oct 20, 2022

It's done and now CAPA is using controller-tools v0.10.0

@pydctw pydctw closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Upgrade controller tools to v0.9.2 pydctw/cluster-api-provider-aws
4 participants
@k8s-ci-robot @pydctw @k8s-triage-robot @sedefsavas