Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add markers defining merge strategy for Server Side Apply to Subnets #3537

Closed
wants to merge 1 commit into from
Closed

[WIP] Add markers defining merge strategy for Server Side Apply to Subnets #3537

wants to merge 1 commit into from

Conversation

pydctw
Copy link
Contributor

@pydctw pydctw commented Jun 16, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add markers defining merge strategy for Server Side Apply to Subnets spec.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3536

Special notes for your reviewer:
This is a WIP PR that needs to be updated when the following two issues are completed to properly generate CRD manifests.

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Add list markers to SubnetSpec
12218f8 
This is to allow a co-authored slice between CAPI and CAPA in server
side apply.

Hacks
* update type definition for CRD generation purpose
* make id field as a required manually
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign justinsb after the PR has been reviewed.
You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Jun 16, 2022 •
edited
Loading

Ignore any test failures as it is expected at this stage with some hacks.

@k8s-ci-robot
Copy link
Contributor

@pydctw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-test 12218f8 link true /test pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify 12218f8 link true /test pull-cluster-api-provider-aws-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pydctw
Copy link
Contributor Author

pydctw commented Jun 16, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022
@pydctw
Copy link
Contributor Author

pydctw commented Jul 27, 2022

#3528 needs to be done first.

Closing for now.

@pydctw pydctw closed this Jul 27, 2022
@pydctw pydctw deleted the ssa-poc branch November 9, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthorsen dthorsen Awaiting requested review from dthorsen

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add markers defining merge strategy for Server Side Apply to Subnet spec
2 participants
@pydctw @k8s-ci-robot