Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vincepri to cluster-api-aws-maintainers #111

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

vincepri
Copy link
Member

What this PR does / why we need it:
Add myself to cluster-api-aws-maintainers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
None

Special notes for your reviewer:
None

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2018
@vincepri vincepri requested review from detiber and chuckha and removed request for roberthbailey and davidewatson September 25, 2018 21:55
@chuckha
Copy link
Contributor

chuckha commented Sep 25, 2018

/approve
/assign @detiber

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2018
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering Vince's contributions to date, I fully support this change.

OWNERS_ALIASES Outdated
@@ -1,4 +1,4 @@
# See the OWNERS docs: https://git.k8s.io/community/docs/devel/owners.md
# See the OWNERS docs: https://git.k8s.io/communitydocs/devel/owners.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this part of the diff made me check both versions of the links and it looks like neither currently work. It looks like it should be https://git.k8s.io/community/contributors/guide/owners.md instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing :)

@detiber
Copy link
Member

detiber commented Sep 25, 2018

/hold

Assigning others in the cluster-api-aws-maintainers alias to allow for lazy consensus. If there are no objections prior to 02 October 2018 I plan on removing the hold to allow for merging.

/assign @davidewatson
/assign @d-nishi
/assign @enxebre
/assign @ingvagabund

@k8s-ci-robot
Copy link
Contributor

@detiber: GitHub didn't allow me to assign the following users: d-nishi, enxebre.

Note that only kubernetes-sigs members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/hold

Assigning others in the cluster-api-aws-maintainers alias to allow for lazy consensus. If there are no objections prior to 02 October 2018 I plan on removing the hold to allow for merging.

/assign @davidewatson
/assign @d-nishi
/assign @enxebre
/assign @ingvagabund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2018
@detiber
Copy link
Member

detiber commented Sep 25, 2018

@d-nishi @enxebre It looks like we need to get both of you added to the kubernetes-sigs org, can you please request membership?

Signed-off-by: Vince Prignano <vince@vincepri.com>
@timothysc
Copy link
Member

LGTM

@davidewatson
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, davidewatson, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chuckha,davidewatson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@d-nishi
Copy link

d-nishi commented Oct 1, 2018

@detiber here is my request: kubernetes/org#126 (comment) - should be complete today.

@detiber
Copy link
Member

detiber commented Oct 2, 2018

/cancel hold
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@detiber
Copy link
Member

detiber commented Oct 2, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8bddce2 into kubernetes-sigs:master Oct 2, 2018
@vincepri vincepri deleted the add-me-maintainer branch October 15, 2018 19:56
paulfantom pushed a commit to paulfantom/cluster-api-provider-aws that referenced this pull request Dec 4, 2018
…p-command-to-crd

Switch aws-actuator bootstrap to deploy CRD based machine API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants