-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vincepri to cluster-api-aws-maintainers #111
Add vincepri to cluster-api-aws-maintainers #111
Conversation
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering Vince's contributions to date, I fully support this change.
OWNERS_ALIASES
Outdated
@@ -1,4 +1,4 @@ | |||
# See the OWNERS docs: https://git.k8s.io/community/docs/devel/owners.md | |||
# See the OWNERS docs: https://git.k8s.io/communitydocs/devel/owners.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this part of the diff made me check both versions of the links and it looks like neither currently work. It looks like it should be https://git.k8s.io/community/contributors/guide/owners.md instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing :)
/hold Assigning others in the /assign @davidewatson |
@detiber: GitHub didn't allow me to assign the following users: d-nishi, enxebre. Note that only kubernetes-sigs members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Vince Prignano <vince@vincepri.com>
0c50dbc
to
0155bc9
Compare
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, davidewatson, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@detiber here is my request: kubernetes/org#126 (comment) - should be complete today. |
/cancel hold |
/hold cancel |
…p-command-to-crd Switch aws-actuator bootstrap to deploy CRD based machine API
What this PR does / why we need it:
Add myself to cluster-api-aws-maintainers.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):None
Special notes for your reviewer:
None
Release note: