-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Correct typos in AWSManagedControlPlane types #2153
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This change doesn't affect the API itself, just a typo in the generated docs so I don't mind either way. I was just looking to get #2083 closed off. :) |
Yes, what I mean was the api package changes, because v1alpha4 is the exact copy of v1alpha3 package. When I rebase to this change, it will not be populated in v1alpha4 directory. |
Sorry, yes, I see what you mean now. (Still waking up 😆) I'm happy with whatever. If you want I can hold off on this and update it after the v1alpha4 are in or we can just look at adding it directly into your PR and close off thise and #2083? |
@sedefsavas why don't you rebase your PR on top of this one, and we'll just do one PR? |
Done. Closing this. |
Can't close this =) |
/close |
@randomvariable: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Completed #2083 (generated CRD yaml)
FYI: @windayski
/cc @randomvariable