Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Correct typos in AWSManagedControlPlane types #2153

Closed
wants to merge 2 commits into from
Closed

🐛 Correct typos in AWSManagedControlPlane types #2153

wants to merge 2 commits into from

Conversation

MarcusNoble
Copy link
Contributor

Completed #2083 (generated CRD yaml)

FYI: @windayski

/cc @randomvariable

windayski and others added 2 commits October 30, 2020 10:12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabriziopandini after the PR has been reviewed.
You can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sedefsavas
Copy link
Contributor

/lgtm
Shall we hold all api related changes until we merge v1alpha4 PR #2121
I already created v1alpha4 types, rebasing doesn't add these changes to v1alpha4, it is manual, so we may miss api related changes.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
@MarcusNoble
Copy link
Contributor Author

This change doesn't affect the API itself, just a typo in the generated docs so I don't mind either way. I was just looking to get #2083 closed off. :)

@sedefsavas
Copy link
Contributor

Yes, what I mean was the api package changes, because v1alpha4 is the exact copy of v1alpha3 package. When I rebase to this change, it will not be populated in v1alpha4 directory.
This is a small change so it is fine, this is more of a general comment.

@MarcusNoble
Copy link
Contributor Author

Sorry, yes, I see what you mean now. (Still waking up 😆)

I'm happy with whatever. If you want I can hold off on this and update it after the v1alpha4 are in or we can just look at adding it directly into your PR and close off thise and #2083?

@randomvariable
Copy link
Member

@sedefsavas why don't you rebase your PR on top of this one, and we'll just do one PR?

@sedefsavas
Copy link
Contributor

Done. Closing this.

@sedefsavas
Copy link
Contributor

Can't close this =)
Ready to be closed.

@randomvariable
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants