🐛 Rename the ELB scheme from Internet-facing to internet-facing

[dlipovetsky]

What type of PR is this?

/kind bug

What this PR does / why we need it:

According to AWS documentation, the scheme is lowercase. If the field is
explicitly set to Internet-facing, CAPA fails to recognize the ELB it
has created, because the ELB's scheme is lowercase, i.e.,
internet-facing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2534

Special notes for your reviewer:
Ordinarily, changing the accepted value is a breaking API change. However, cluster create always fails with the current value ( Internet-facing), therefore we can assume that no one is using the current value.

I added this PR to the agenda for our next meeting.

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

Changes the accepted ELB scheme from "Internet-facing" to "internet-facing." Although this is a breaking API change, it should not impact any user, because cluster create always fails with the previous value.

[Ankitasw]

/lgtm

[sedefsavas]

Following up on the discussion during the office hours:

const (
	// LoadBalancerSchemeEnumInternetFacing is a LoadBalancerSchemeEnum enum value
	LoadBalancerSchemeEnumInternetFacing = "internet-facing"

	// LoadBalancerSchemeEnumInternal is a LoadBalancerSchemeEnum enum value
	LoadBalancerSchemeEnumInternal = "internal"
)

@dlipovetsky what you are saying is correct.
Since it was broken before, although this is an API change, we should fix it and make a release soon.

[sedefsavas]

/approve
cc @richardcase @randomvariable

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment