Updates e2e test cluster names to include spec name #3425
Conversation
k8s-ci-robot
added
the
kind/feature
|
|
k8s-ci-robot
added
cncf-cla: no
|
@ydarb: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @ydarb! |
k8s-ci-robot
added
the
needs-triage
|
Hi @ydarb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
size/M
| @@ -57,7 +57,7 @@ var _ = ginkgo.Describe("[unmanaged] [conformance] tests", func() { | |||
| }) | |||
| ginkgo.Measure(specName, func(b ginkgo.Benchmarker) { | |||
|
|
|||
| name := fmt.Sprintf("cluster-%s", util.RandomString(6)) | |||
| name := fmt.Sprintf("cluster-%s-%s", specName, util.RandomString(6)) | |||
There was a problem hiding this comment.
Thanks for the PR @ydarb.
When cluster name is set like this ClusterName: fmt.Sprintf("%s-%s", specName, util.RandomString(6)), template names are appended with -cluster-template as can be seen here:
https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-main/1514973830395727872/artifacts/clusters/bootstrap/
We have an additional prefix cluster here. How about deleting it?
There was a problem hiding this comment.
My apologies. It was late when I made the updates 😄
There was a problem hiding this comment.
@sedefsavas Addressed your comment. Let me know if there is anything else that should be addressed.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Test templates were not reflecting tests that they were for. This PR updates the cluster names in templates to include the spec name.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3424
Special notes for your reviewer:
I replaced all instances of cluster name being set via
fmt.Sprintf("cluster-%s", util.RandomString(6))withfmt.Sprintf("cluster-%s-%s", specName, util.RandomString(6)). Hopefully, I got them all and didn't go overboard 😃Checklist: