Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1beta2 APIs #3720

Merged
merged 6 commits into from
Sep 21, 2022
Merged

v1beta2 APIs #3720

merged 6 commits into from
Sep 21, 2022

Conversation

sedefsavas
Copy link
Contributor

What this PR does / why we need it:
This PR adds new v1beta2 API version and it is the exact copy of v1beta1.
After this PR is merged, v1beta2 changes will come as follow up PRs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

sedefsavas and others added 3 commits September 7, 2022 07:04
@sedefsavas
Add v1beta2 APIs
cdbaf65
@sedefsavas @Ankitasw
Add EKS and EXP v1beta2 APIs
2a4be90 
Co-authored-by: Ankita Swamy <swamyan@vmware.com>
Co-authored-by: Sedef Savas <ssavas@vmware.com>
@sedefsavas @Ankitasw
Change v1beta1 usages to v1beta2
586c87c 
Co-authored-by: Ankita Swamy <swamyan@vmware.com>
Co-authored-by: Sedef Savas <ssavas@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 12, 2022
@sedefsavas sedefsavas force-pushed the v1beta2_latest branch 2 times, most recently from 6e1ec93 to 7b18c94 Compare September 12, 2022 06:00
@Ankitasw
Copy link
Member

/test?

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-blocking

@Skarlso
Copy link
Contributor

Skarlso commented Sep 12, 2022

This looks okay to me compared to previous ways of promoting a new version. But since this is a significant change, I would suggest not just taking my word for it. :D

I'll wait until tests pass for lgtm. :)

@Ankitasw
Copy link
Member

This looks okay to me compared to previous ways of promoting a new version. But since this is a significant change, I would suggest not just taking my word for it. :D

Ahh and it just happened, will fix E2E tests.
@Skarlso All the very best in reviewing this PR though 😛

@Skarlso
Copy link
Contributor

Skarlso commented Sep 12, 2022

@Skarlso All the very best in reviewing this PR though 😛

Bwuhahahaha. :D Yeah, it's quite massive. :D

@Ankitasw
Copy link
Member

Ankitasw commented Sep 12, 2022 •
edited
Loading

Running E2E tests locally, and would commit the fix together, mostly failing because of some of the kubeadm APIs are still v1beta1, and we mistakenly changed it to v1beta2.

Update:
Some other world issue arising while running PR blocking specific tests in local, which I don't want to debug 😄 , hence continuing to test E2E in PR itself.

@Ankitasw Ankitasw force-pushed the v1beta2_latest branch 7 times, most recently from ed4f201 to 8451d6e Compare September 12, 2022 12:10
@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-blocking

1 similar comment
@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-blocking

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-clusterclass

@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e-conformance

@sedefsavas sedefsavas mentioned this pull request Sep 13, 2022
Merged
@sedefsavas sedefsavas mentioned this pull request Sep 15, 2022
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@sedefsavas
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e

@sedefsavas sedefsavas force-pushed the v1beta2_latest branch 2 times, most recently from de4204b to 14109e7 Compare September 15, 2022 19:39
@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member

@richardcase @Skarlso This is ready for final review.

@Skarlso
Copy link
Contributor

Skarlso commented Sep 16, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2022
@luthermonson
Copy link
Contributor

🚀

richardcase
richardcase reviewed Sep 20, 2022
View reviewed changes
Makefile Show resolved Hide resolved
api/v1beta2/bastion.go Show resolved Hide resolved
config/crd/kustomization.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2022
@Ankitasw Ankitasw force-pushed the v1beta2_latest branch 3 times, most recently from 83a793d to a430b09 Compare September 20, 2022 10:40
@Skarlso
Copy link
Contributor

Skarlso commented Sep 20, 2022

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e

@yastij
Copy link
Member

yastij commented Sep 20, 2022

/assign

@richardcase
Copy link
Member

Based on review, discussions and e2e passing:

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Sep 21, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 852f846 into kubernetes-sigs:main Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Sep 21, 2022
@Ankitasw Ankitasw deleted the v1beta2_latest branch March 8, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ankitasw Ankitasw Ankitasw left review comments

@richardcase richardcase richardcase left review comments

@Skarlso Skarlso Skarlso left review comments

@shivi28 shivi28 Awaiting requested review from shivi28

Assignees

@Skarlso Skarlso

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sedefsavas @Ankitasw @k8s-ci-robot @Skarlso @richardcase @luthermonson @yastij