Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 chore: title verifier update #5300

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the PR title checker to be inline with upstream CAPI. Also, this will help with some PR failures with auth.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Update PR verifier to be inline with upstream CAPI.

Updates the PR title checker to be inline with upstream CAPI. Also,
this will help with some PR failures with auth.

Signed-off-by: Richard Case <richard.case@outlook.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2025
@richardcase
Copy link
Member Author

/cherrypick release-2.7
/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

@k8s-infra-cherrypick-robot

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.4, release-2.5, release-2.6, release-2.7 in new PRs and assign them to you.

In response to this:

/cherrypick release-2.7
/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nrb
Copy link
Contributor

nrb commented Jan 21, 2025

/approve
/hold
/assign @damdo @AndiDog

Feel free to remove hold if it gets the lgtm.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@nrb
Copy link
Contributor

nrb commented Jan 21, 2025

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1c280ad into kubernetes-sigs:main Jan 21, 2025
24 checks passed
@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5302

In response to this:

/cherrypick release-2.7
/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5303

In response to this:

/cherrypick release-2.7
/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5307

In response to this:

/cherrypick release-2.7
/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@richardcase: new pull request created: #5308

In response to this:

/cherrypick release-2.7
/cherrypick release-2.6
/cherrypick release-2.5
/cherrypick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants