✨ Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools #5319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-priority
size/XL
|
/test pull-cluster-api-provider-aws-e2e |
…anagedMachinePools Co-authored-by: Cameron McAvoy <cmcavoy@indeed.com>
AndiDog
force-pushed
the
awsmachinepool-awsmachines
branch
from
3ff118b to
3b9f60f
Compare
|
/test pull-cluster-api-provider-aws-e2e |
|
/test pull-cluster-api-provider-aws-e2e-eks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Replaces #5174 because of branch issues.
This implements the CAPI MachinePool Machines proposal.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4184
Special notes for your reviewer:
Revival of #4527. I took @cnmcavoy's great effort and got it fully working. I tested EC2 cluster creation, machine deletion by user, instance creation and termination by ASG scaling, instance termination by user, ...
Checklist:
Release note:
/assign cnmcavoy
(original author)
/assign richardcase
(CC @sl1pm4t since you were on the previous instance of this PR)