Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ec2:DescribeAccountAttributes to bootstrap user #630

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

joejulian
Copy link
Contributor

What this PR does / why we need it:
Reconciling load balancers fails with an error stating that it needs
ec2:DescribeAccountAttributes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #629

Special notes for your reviewer:

Release note:

Added `ec2:DescribeAccountAttributes` to bootstrap user permissions.
action required: Run `clusterawsadm alpha bootstrap create-stack` to apply the new permissions

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @joejulian. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2019
@joejulian
Copy link
Contributor Author

Not sure why it failed the CLA check. This is not my first contribution to a CNCF project.

@ashish-amarnath
Copy link
Contributor

ashish-amarnath commented Mar 6, 2019

@joejulian maybe the email and user in your gitconfig?

For a PR to pass, each commit must pass this check: the Github user that the commit is attributed to (based on a match between the commit authorship and Github profile) must be linked to a Linux Foundation ID user (on the "social network logins" tab), who is authorized by a signed ICLA and/or a CCLA.

@justaugustus
Copy link
Member

@joejulian -- might want to check that your email listed here is accurate: https://github.com/cncf/gitdm/blob/master/developers_affiliations1.txt

/check-cla

@ashish-amarnath
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2019
@detiber
Copy link
Member

detiber commented Mar 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@vincepri
Copy link
Member

vincepri commented Mar 7, 2019

/milestone v1alpha1

@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Mar 7, 2019
@joejulian
Copy link
Contributor Author

Author: Joe Julian <me@joejulian.name>
https://github.com/cncf/gitdm/blob/master/developers_affiliations1.txt#L19079
/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Mar 8, 2019
@chuckha
Copy link
Contributor

chuckha commented Mar 8, 2019

/check-cla

@joejulian
Copy link
Contributor Author

I signed it

@chuckha
Copy link
Contributor

chuckha commented Mar 8, 2019

I know, I was just trying to get it to update :/

@joejulian
Copy link
Contributor Author

That's what https://identity.linuxfoundation.org/projects/cncf says I'm supposed to do. :)

@joejulian
Copy link
Contributor Author

Also... hahaha, prow, I didn't know you had a shrug label. :D

@joejulian
Copy link
Contributor Author

Opened an issue: https://jira.linuxfoundation.org/browse/CL-94

@vincepri
Copy link
Member

/check-cla

@joejulian
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 11, 2019
@joejulian
Copy link
Contributor Author

/noshrug
no idea why I had to sign it again. Whatever. It's not like these things are enforceable.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @chuckha

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joejulian, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0819fcb into kubernetes-sigs:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to reconcile load balancers - not authorized to perform: ec2:DescribeAccountAttributes
7 participants