-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ec2:DescribeAccountAttributes to bootstrap user #630
Add ec2:DescribeAccountAttributes to bootstrap user #630
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @joejulian. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not sure why it failed the CLA check. This is not my first contribution to a CNCF project. |
@joejulian maybe the email and user in your gitconfig?
|
@joejulian -- might want to check that your email listed here is accurate: https://github.com/cncf/gitdm/blob/master/developers_affiliations1.txt /check-cla |
/ok-to-test |
/lgtm |
/milestone v1alpha1 |
|
/check-cla |
I signed it |
I know, I was just trying to get it to update :/ |
That's what https://identity.linuxfoundation.org/projects/cncf says I'm supposed to do. :) |
Also... hahaha, prow, I didn't know you had a shrug label. :D |
Opened an issue: https://jira.linuxfoundation.org/browse/CL-94 |
/check-cla |
I signed it |
/noshrug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @chuckha
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joejulian, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Reconciling load balancers fails with an error stating that it needs
ec2:DescribeAccountAttributes
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #629
Special notes for your reviewer:
Release note: