fix lb tests

kubernetes-sigs · Oct 10, 2020 · 286fd9a · 286fd9a
1 parent 74254f3
commit 286fd9a
Show file tree

Hide file tree

Showing 4 changed files with 128 additions and 246 deletions.
diff --git a/cloud/scope/cluster.go b/cloud/scope/cluster.go
@@ -126,7 +126,6 @@ func (s *ClusterScope) LBSpecs() []azure.LBSpec {
 			// Control Plane LB
 			Name:              s.APIServerLB().Name,
 			SubnetName:        s.ControlPlaneSubnet().Name,
-			SubnetCidrs:       s.ControlPlaneSubnet().CIDRBlocks,
 			FrontendIPConfigs: s.APIServerLB().FrontendIPs,
 			APIServerPort:     s.APIServerPort(),
 			Type:              s.APIServerLB().Type,

diff --git a/cloud/services/loadbalancers/loadbalancers.go b/cloud/services/loadbalancers/loadbalancers.go
@@ -37,7 +37,6 @@ func (s *Service) Reconcile(ctx context.Context) error {
 		}
 
 		lb := network.LoadBalancer{
-			Name:     to.StringPtr(lbSpec.Name),
 			Sku:      &network.LoadBalancerSku{Name: network.LoadBalancerSkuNameStandard},
 			Location: to.StringPtr(s.Scope.Location()),
 			Tags: converters.TagsToMap(infrav1.Build(infrav1.BuildParams{
@@ -110,6 +109,7 @@ func (s *Service) Reconcile(ctx context.Context) error {
 					},
 				},
 			}
+			// TODO: check if this is needed for outbound access
 			if lbSpec.Type == infrav1.Internal {
 				lb.LoadBalancerPropertiesFormat.OutboundRules = nil
 			}