Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Infrastructure resource from machine controller #1129

Closed
enxebre opened this issue Jan 20, 2021 · 5 comments
Closed

Decouple Infrastructure resource from machine controller #1129

enxebre opened this issue Jan 20, 2021 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone

Comments

@enxebre
Copy link
Member

enxebre commented Jan 20, 2021

/kind feature

Describe the solution you'd like
As a CAPI consumer I'd like to plug-in my own ControlPlane and Infrastructure resources [1] while still still reusing the existing machine controller implementation.

Today this is not possible because the machine/machinePool controllers are tightly coupled with the regular AzureCluster kind [2].

A scenario where this is handy is one where there's a common vision for a controlPlane across providers e.g cluster-api-provider-nested and the infrastructure management can differ arbitrarily from the core implementations, e.g BYO.

[1] https://github.com/kubernetes-sigs/cluster-api/blob/master/api/v1alpha4/cluster_types.go#L50-L58
[2] https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/controllers/azuremachine_controller.go#L186-L204

Anything else you would like to add:
Analogous to AWS
kubernetes-sigs/cluster-api-provider-aws#2125
kubernetes-sigs/cluster-api-provider-aws#2124

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@CecileRobertMichon
Copy link
Contributor

As discussed in Slack, let's start with a proposal.

/milestone v0.5.x

@k8s-ci-robot k8s-ci-robot added this to the v0.5.x milestone Jan 20, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2021
@CecileRobertMichon
Copy link
Contributor

/remove lifecycle-frozen

Proposal kubernetes-sigs/cluster-api#4135

@CecileRobertMichon
Copy link
Contributor

/close

done in #1389

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closing this issue.

In response to this:

/close

done in #1389

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants