Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all occurrences of ToNot(HaveOccurred()) #1866

Closed
CecileRobertMichon opened this issue Nov 16, 2021 · 5 comments · Fixed by #1891
Closed

Replace all occurrences of ToNot(HaveOccurred()) #1866

CecileRobertMichon opened this issue Nov 16, 2021 · 5 comments · Fixed by #1891
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Nov 16, 2021

Replace all occurrences of Expect(err).To(HaveOccurred()) with (Expect(err).NotTo(HaveOccurred()) (ToNot -> NotTo)

Nit: I prefer NotTo because it doesn't split an infinitive (yes I know that's considered an archaic rule, but it still sounds wrong to me)

-- @mboersma

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Replace all occurrences of Expect(err).NotTo(HaveOccurred()) with Expect(err).To(HaveOccurred()) (NotTo -> ToNot)

Nit: I prefer NotTo because it doesn't split an infinitive (yes I know that's considered an archaic rule, but it still sounds wrong to me).

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 16, 2021
@Evalle
Copy link
Contributor

Evalle commented Nov 16, 2021

/assign

@Evalle
Copy link
Contributor

Evalle commented Nov 24, 2021

Hi @CecileRobertMichon @mboersma is it an internal joke or should we really add the change?
According to this comment @mboersma prefers to have NotTo :)

@CecileRobertMichon
Copy link
Contributor Author

@Evalle my apologies, I messed up the order in the description :D

it should be replace all occurrences of ToNot... will fix the description

/retitle Replace all occurrences of ToNot(HaveOccurred())

@k8s-ci-robot k8s-ci-robot changed the title Replace all occurrences of NotTo(HaveOccurred()) Replace all occurrences of ToNot(HaveOccurred()) Nov 24, 2021
@Evalle
Copy link
Contributor

Evalle commented Nov 25, 2021

I see :) thanks for the clarification. Let me create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants