Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We haven't upgraded kustomize in a while. There was a bug found in #1388 (comment) that didn't serialize integers correctly.
The version bump from 0.3.6 to 0.3.7 broke the way patches are used (https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.7 and kubernetes-sigs/kustomize#2342)
The docs say:
which is why we had to update the patchesJson to use regular expressions vs just the
${CLUSTER_NAME}-md-0
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
I did each upgrade on a separate commit to track the changes required.
Can't go past 4.0.4 because 4.0.5+ introduce a white space break on long linds in yaml.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: