Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go modules #231

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Go modules #231

merged 1 commit into from
Jul 12, 2019

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Jul 11, 2019 •
edited
Loading

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #195

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Updates the repository to use Go modules.
Updates Azure SDK to v31.1.0+incompatible.
Updates Azure go-autorest to v11.5.2+incompatible.

@k8s-ci-robot
Copy link
Contributor

Welcome @vincepri!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. area/provider/azure Issues or PRs related to azure provider labels Jul 11, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 11, 2019
@vincepri vincepri force-pushed the go-modules branch 2 times, most recently from 4436fc8 to 4322dbf Compare July 11, 2019 16:08
@vincepri
Copy link
Member Author

Note that his also updated the Azure Go SDK to the latest version

@vincepri
Copy link
Member Author

/assign @justaugustus

justaugustus
justaugustus suggested changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincepri -- This is amazing! Switching to go modules was on my backlog, so you're saving me a bunch of time. ❤️

I dropped a few nits as code suggestions.

Additionally, before we merge this, we need to make sure capz developers know how to manipulate dependencies, now that they're changing dramatically.

Can you add notes in docs/development.md which link out to docs/dependencies.md which detail the new hack scripts that were added, as well as how to bump modules?

BUILD.bazel Show resolved Hide resolved
build/controller_gen.bzl Outdated Show resolved Hide resolved
build/controller_gen.bzl Outdated Show resolved Hide resolved
go.mod Outdated
github.com/Azure/azure-sdk-for-go v31.1.0+incompatible
github.com/Azure/go-autorest v11.5.2+incompatible
github.com/appscode/jsonpatch v0.0.0-20190108182946-7c0e3b262f30 // indirect
github.com/census-instrumentation/opencensus-proto v0.1.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this works. I was running into issues here:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have had the same issue in CAPA, but it seems that doesn't happen when using go mod

go.vendor Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@justaugustus
Copy link
Contributor

One more thing... please capture the azure-sdk-for-go and go-autorest version changes in the PR description, so it's easier to reference if we need to later.

@vincepri vincepri force-pushed the go-modules branch 2 times, most recently from 4589a87 to 5825951 Compare July 12, 2019 00:30
@vincepri
Go modules
321abe9 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@justaugustus
Copy link
Contributor

Thanks again, @vincepri!

Alright, here goes nothing... :shipit:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@alexeldeib
Copy link
Contributor

Alt Text

@k8s-ci-robot k8s-ci-robot merged commit efed85b into kubernetes-sigs:master Jul 12, 2019
@justaugustus
Copy link
Contributor

/pony party

@k8s-ci-robot
Copy link
Contributor

@justaugustus: pony image

In response to this:

/pony party

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Contributor

...and maybe a doggo for good measure
/woof

@k8s-ci-robot
Copy link
Contributor

@justaugustus: dog image

In response to this:

...and maybe a doggo for good measure
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hidekazuna hidekazuna mentioned this pull request Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@davidopp davidopp Awaiting requested review from davidopp

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate go modules
4 participants
@vincepri @k8s-ci-robot @justaugustus @alexeldeib