Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: publish ref images to Compute Gallery #3370

Closed

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Mar 29, 2023

What type of PR is this?

/kind design

What this PR does / why we need it:

Adds a proposal to make publishing CAPZ reference images to Azure Compute Gallery the default.

Which issue(s) this PR fixes:

Refs #2294
Fixes #4163

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Proposal: publish ref images to Compute Gallery

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/design Categorizes issue or PR as related to design. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma force-pushed the proposal-azure-compute-gallery branch from d1eb3bb to 285bf49 Compare March 30, 2023 16:47
@mboersma mboersma force-pushed the proposal-azure-compute-gallery branch from 285bf49 to 17794a6 Compare April 10, 2023 21:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c125458) 51.64% compared to head (17794a6) 51.64%.
Report is 1155 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3370   +/-   ##
=======================================
  Coverage   51.64%   51.64%           
=======================================
  Files         182      182           
  Lines       18066    18066           
=======================================
  Hits         9331     9331           
  Misses       8208     8208           
  Partials      527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,24 @@
#!/bin/bash
Copy link
Member

@invidian invidian May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here is internal Flatcar script which is used right now for building and publishing images to a community gallery: https://gist.github.com/invidian/41331399454b671f4f02ca693c731152. It also includes a staging gallery stage for testing.

EDIT: Also for reference here is the whole discussion about Flatcar images publishing: flatcar/Flatcar#734.

@mboersma mboersma self-assigned this May 22, 2023
@mboersma mboersma added this to the next milestone Sep 11, 2023
@mboersma mboersma modified the milestones: next, v1.11, v1.12 Sep 18, 2023
@mboersma
Copy link
Contributor Author

/milestone next

I've made great progress locally on prototyping this, but it's not going to come together in time for the v1.12 release this week.

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.12, next Nov 13, 2023
@dtzar dtzar modified the milestones: next, v1.13 Nov 16, 2023
@mboersma mboersma removed their assignment Dec 14, 2023
@mboersma mboersma self-assigned this Dec 14, 2023
@mboersma mboersma modified the milestones: v1.13, next, v1.14 Jan 16, 2024
@nojnhuh nojnhuh modified the milestones: v1.14, next Feb 29, 2024
@mboersma mboersma modified the milestones: next, v1.15 Mar 13, 2024
@mboersma
Copy link
Contributor Author

/close

I'm closing this for now to avoid distraction. It's backed up behind a couple other items:

  • Remove go-dev container dependency
  • Move all pipelines to Managed ID
  • Maybe move pipelines from ADO to GH Actions

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

I'm closing this for now to avoid distraction. It's backed up behind a couple other items:

  • Remove go-dev container dependency
  • Move all pipelines to Managed ID
  • Maybe move pipelines from ADO to GH Actions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/design Categorizes issue or PR as related to design. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Share VM images via Azure Compute Galleries
6 participants