-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: publish ref images to Compute Gallery #3370
Proposal: publish ref images to Compute Gallery #3370
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d1eb3bb
to
285bf49
Compare
285bf49
to
17794a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3370 +/- ##
=======================================
Coverage 51.64% 51.64%
=======================================
Files 182 182
Lines 18066 18066
=======================================
Hits 9331 9331
Misses 8208 8208
Partials 527 527 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,24 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, here is internal Flatcar script which is used right now for building and publishing images to a community gallery: https://gist.github.com/invidian/41331399454b671f4f02ca693c731152. It also includes a staging gallery stage for testing.
EDIT: Also for reference here is the whole discussion about Flatcar images publishing: flatcar/Flatcar#734.
/milestone next I've made great progress locally on prototyping this, but it's not going to come together in time for the v1.12 release this week. |
/close I'm closing this for now to avoid distraction. It's backed up behind a couple other items:
|
@mboersma: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind design
What this PR does / why we need it:
Adds a proposal to make publishing CAPZ reference images to Azure Compute Gallery the default.
Which issue(s) this PR fixes:
Refs #2294
Fixes #4163
Special notes for your reviewer:
TODOs:
Release note: