Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use token input instead of env for codecov #4934

Closed
wants to merge 1 commit into from

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jun 21, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

I have a hypothesis that the recent changes to codecov to use tokens defined in forks to get around the rate limits associated with tokenless uploads requires the token input to be set instead of the CODECOV_TOKEN environment variable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nojnhuh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.19%. Comparing base (287fa1f) to head (2172f0b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4934      +/-   ##
==========================================
+ Coverage   62.18%   62.19%   +0.01%     
==========================================
  Files         201      201              
  Lines       16878    16878              
==========================================
+ Hits        10495    10497       +2     
+ Misses       5593     5591       -2     
  Partials      790      790              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor

Seems like #4935 needs this fix.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 24, 2024

I'm not sure yet that this actually fixes anything, given this message is what I was hoping to avoid:
https://github.com/kubernetes-sigs/cluster-api-provider-azure/actions/runs/9617996856/job/26543508140?pr=4934#step:7:8

==> Fork detected, tokenless uploading used

I think I might try bumping the codecov action version here and see if that at least gets the job to succeed at all.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 24, 2024

I'm thinking my hypothesis is wrong here so I don't think this actually makes any meaningful difference.

/close

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Closed this PR.

In response to this:

I'm thinking my hypothesis is wrong here so I don't think this actually makes any meaningful difference.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh nojnhuh deleted the codecov-token branch September 20, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants