Skip to content

Commit

Permalink
allow updating the control plane endpoint if previously set (#335)
Browse files Browse the repository at this point in the history
  • Loading branch information
varshavaradarajan authored Jul 26, 2022
1 parent 107d37d commit 0507d7d
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions api/v1beta1/docluster_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,11 @@ package v1beta1

import (
"fmt"
"reflect"

apierrors "k8s.io/apimachinery/pkg/api/errors"
runtime "k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/util/validation/field"

clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
ctrl "sigs.k8s.io/controller-runtime"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/webhook"
Expand Down Expand Up @@ -68,10 +66,6 @@ func (r *DOCluster) ValidateUpdate(old runtime.Object) error {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "region"), r.Spec.Region, "field is immutable"))
}

if !reflect.DeepEqual(clusterv1.APIEndpoint{}, oldDOCluster.Spec.ControlPlaneEndpoint) && !reflect.DeepEqual(r.Spec.ControlPlaneEndpoint, oldDOCluster.Spec.ControlPlaneEndpoint) {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "controlPlaneEndpoint"), r.Spec.ControlPlaneEndpoint, "field is immutable"))
}

if len(allErrs) == 0 {
return nil
}
Expand Down

0 comments on commit 0507d7d

Please sign in to comment.