Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controlPlaneEndpoint validation error message #287

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Fix controlPlaneEndpoint validation error message #287

merged 1 commit into from
Dec 16, 2021

Conversation

timoreimann
Copy link
Contributor

What this PR does / why we need it:
Fixes the validation error message around controlPlaneEndpoint that incorrectly showed the content of the region due to a copy-paste mistake.

Release note:

Fix controlPlaneEndpoint validation error message

/assign @cpanato @MorrisLaw

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@cpanato
Copy link
Member

cpanato commented Dec 15, 2021

/test ls

@k8s-ci-robot
Copy link

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-digitalocean-build
  • /test pull-cluster-api-provider-digitalocean-e2e
  • /test pull-cluster-api-provider-digitalocean-lint
  • /test pull-cluster-api-provider-digitalocean-test
  • /test pull-cluster-api-provider-digitalocean-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-digitalocean-capi-e2e
  • /test pull-cluster-api-provider-digitalocean-capi-e2e-experimental
  • /test pull-cluster-api-provider-digitalocean-conformance

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-digitalocean-build
  • pull-cluster-api-provider-digitalocean-e2e
  • pull-cluster-api-provider-digitalocean-lint
  • pull-cluster-api-provider-digitalocean-test
  • pull-cluster-api-provider-digitalocean-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented Dec 15, 2021

/test pull-cluster-api-provider-digitalocean-capi-e2e
/test pull-cluster-api-provider-digitalocean-conformance

/hold for nono required tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2021
cpanato
cpanato approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, timoreimann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,timoreimann]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Dec 16, 2021

@timoreimann can you cherry pick this to the release-1.0 branch? thanks!

@cpanato
Copy link
Member

cpanato commented Dec 16, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit a16e0ec into kubernetes-sigs:main Dec 16, 2021
@timoreimann
Copy link
Contributor Author

/cherrypick release-1.0

@cpanato
Copy link
Member

cpanato commented Dec 17, 2021

/cherrypick release-1.0

there is no automation for that :)

@timoreimann timoreimann mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@cpanato cpanato

@MorrisLaw MorrisLaw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timoreimann @cpanato @k8s-ci-robot @MorrisLaw